Skip to content

feat: implement imodintro and imod#141

Merged
MackieLoeffel merged 5 commits intomasterfrom
msammler/imodintro
Feb 2, 2026
Merged

feat: implement imodintro and imod#141
MackieLoeffel merged 5 commits intomasterfrom
msammler/imodintro

Conversation

@MackieLoeffel
Copy link
Collaborator

@MackieLoeffel MackieLoeffel commented Jan 29, 2026

Description

This PR implements the imodintro tactic and adds the !> intro pattern for introducing modalities.
Additionally, it implements imod and the > cases pattern.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have updated PORTING.md as appropriate
  • I have added my name to the authors section of any appropriate files

@MackieLoeffel MackieLoeffel changed the title feat: implement imodintro feat: implement imodintro and imod Jan 30, 2026
@MackieLoeffel
Copy link
Collaborator Author

@lzy0505 This PR is ready to review.

@lzy0505
Copy link
Collaborator

lzy0505 commented Feb 1, 2026

Great PR! I’ve added some code comments. A minor improvement would be the error message for inext. You can see it in the last test case I added. The PR is ready to merge anyway.

@MackieLoeffel
Copy link
Collaborator Author

Thanks for the review and the changes! It is a bit tricky to tweak the error for inext, so I would leave it as is for the moment.

@MackieLoeffel MackieLoeffel merged commit cc6b3cb into master Feb 2, 2026
1 check passed
@MackieLoeffel MackieLoeffel deleted the msammler/imodintro branch February 2, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants