Skip to content

fixes for lean PR 12225#166

Open
JovanGerb wants to merge 6 commits intoleanprover-community:nightly-testingfrom
JovanGerb:testing-12225-fixes
Open

fixes for lean PR 12225#166
JovanGerb wants to merge 6 commits intoleanprover-community:nightly-testingfrom
JovanGerb:testing-12225-fixes

Conversation

@JovanGerb
Copy link


Open in Gitpod

@JovanGerb
Copy link
Author

!bench

@leanprover-radar
Copy link

leanprover-radar commented Jan 29, 2026

Benchmark results for 4198f04 against ae00d67 are in! @JovanGerb

  • 🟥 main exited with code 1

No significant changes detected.

@JovanGerb JovanGerb changed the base branch from lean-pr-testing-12225 to nightly-testing January 29, 2026 15:35
@JovanGerb
Copy link
Author

!bench

@leanprover-radar
Copy link

leanprover-radar commented Jan 29, 2026

Benchmark results for 2560e4a against e0bf30b are in! @JovanGerb

  • build//instructions: +5.4T (+3.1%)

No significant changes detected.

@Garmelon
Copy link

Note that the bot doesn't yet use the mathlib significance thresholds

@JovanGerb
Copy link
Author

I have encountered a couple of annoying problems when testing these adaptations

  • I would have wanted to push to the autogenerated adaptation branch directly
  • Since I don't have this right, I made a PR to the adaptation branch
  • This doesn't run CI, so I have to build mathlib locally
  • When running !bench on the PR, it compares the result with the adaptation branch, instead of the nightly-testing branch. So to get the right !bench result, I had to change the base branch of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants