[Merged by Bors] - feat: action for labeling and closing stale PRs#17041
Closed
bryangingechen wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - feat: action for labeling and closing stale PRs#17041bryangingechen wants to merge 5 commits intomasterfrom
bryangingechen wants to merge 5 commits intomasterfrom
Conversation
bryangingechen
added
the
CI
PR summary ad1c63d501Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
mattrobball
approved these changes
Oct 16, 2024
| @@ -0,0 +1,25 @@ | |||
| name: 'Close stale issues and PRs' | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| name: 'Close stale issues and PRs' | |
| name: 'Flag and then close stale PRs' |
is more appropriate?
| # "is:open is:pr -is:draft base:master sort:updated-asc status:success -label:blocked-by-other-PR -label:merge-conflict -label:awaiting-CI -label:WIP -label:awaiting-author -label:delegated -label:auto-merge-after-CI -label:ready-to-merge -label:please-adopt -label:help-wanted -label:awaiting-zulip" | ||
| # We want PRs _not_ on the queue, so we keep "is:pr -is:draft base:master" (is:open is added by the action by default) as a prefix for all queries and then negate the rest of the params in separate queries to simulate boolean OR (see https://github.com/actions/stale/pull/1145) | ||
| # except for label:auto-merge-after-CI and label:ready-to-merge which presumably will be noticed before they go stale | ||
| only-matching-filter: '[ "is:pr -is:draft base:master -status:success", "is:pr -is:draft base:master label:blocked-by-other-PR", "is:pr -is:draft base:master label:merge-conflict", "is:pr -is:draft base:master label:awaiting-CI", "is:pr -is:draft base:master label:WIP", "is:pr -is:draft base:master label:awaiting-author", "is:pr -is:draft base:master label:delegated", "is:pr -is:draft base:master label:please-adopt", "is:pr -is:draft base:master label:help-wanted", "is:pr -is:draft base:master label:awaiting-zulip" ]' |
Collaborator
There was a problem hiding this comment.
Arguably we should be more aggressive about delegated and ready-to-merge but that can come later.
Collaborator
|
Thanks! Let's try this out. bors delegate+ |
Contributor
|
✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Per discussion in the maintainer channel. Uses a PR branch actions/stale#1145 of [actions/stale](https://github.com/actions/stale/) since it has a feature that will allow us to only consider PRs not sitting on the [#queue](https://bit.ly/3Ymuh0U). There's still placeholder text for the comments, but this is intended to be merged with the `debug-only` flag until we have the kinks sorted out, so we could fill in that text in a later PR.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in the maintainer channel.
Uses a PR branch actions/stale#1145 of actions/stale since it has a feature that will allow us to only consider PRs not sitting on the #queue.
There's still placeholder text for the comments, but this is intended to be merged with the
debug-onlyflag until we have the kinks sorted out, so we could fill in that text in a later PR.