fix: use gh release create instead of action-gh-release#12180
Merged
Conversation
This PR switches the PR release workflow from `softprops/action-gh-release` to `gh release create`. The `softprops/action-gh-release` action enumerates all releases to check for existing ones, which fails when the repository has more than 10000 releases due to GitHub API pagination limits. The `lean4-pr-releases` repository has accumulated over 10000 releases, causing the PR release workflow to fail with: "Only the first 10000 results are available." 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
Note: I've also opened an upstream fix at softprops/action-gh-release#725. If that PR is merged and released, we could revert this change and go back to using |
Add a check that artifacts were downloaded successfully before attempting to create the release. This is equivalent to the `fail_on_unmatched_files: true` option in the old `softprops/action-gh-release` action. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
kim-em
force-pushed
the
fix-pr-release-10k-limit
branch
from
f59b882 to
971a116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the PR release workflow from
softprops/action-gh-releasetogh release create.The
softprops/action-gh-releaseaction enumerates all releases to check for existing ones, which fails when the repository has more than 10000 releases due to GitHub API pagination limits. Thelean4-pr-releasesrepository has accumulated over 10000 releases, causing the PR release workflow to fail with:This is currently blocking all PR toolchain releases, including #12175.
🤖 Prepared with Claude Code