Add manual tax entry on orders and quotes#8930
Draft
ehuelsmann wants to merge 2 commits intoledgersmb:masterfrom
Draft
Add manual tax entry on orders and quotes#8930ehuelsmann wants to merge 2 commits intoledgersmb:masterfrom
ehuelsmann wants to merge 2 commits intoledgersmb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for defining manual tax entries on orders/quotes and ensures these are persisted and reloaded instead of automatically recalculating taxes.
- Wraps existing tax calculation in
save()with amanual_taxcheck and inserts manual tax rows when enabled - Queries and populates manual tax values in
retrieve()if saved entries exist - Updates Changelog to document the new manual-tax feature and its effect on recalculation
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| old/lib/LedgerSMB/OE.pm | Added conditional branches in save()/retrieve() to handle manual taxes |
| Changelog | Noted ability to manually enter taxes and changed tax recalculation behavior |
Comments suppressed due to low confidence (1)
old/lib/LedgerSMB/OE.pm:301
- Consider adding automated tests to cover the new manual-tax entry and retrieval logic to validate both save and load flows.
if (!$form->{manual_tax}){
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On request of @freelock, added manual taxes on orders.
After this change, tax recalculation on the order requires the user to switch the order back to Automatic, which recalculates (and switches back to Manual after saving).
Problems that need addressing: