Skip to content

Conversation

@roj234
Copy link
Contributor

@roj234 roj234 commented Feb 3, 2026

Also easier to edit and keep git log small
Only tested on LLVM-MinGW
Require some refactor to action script

(cherry picked from commit be84a3d)

@roj234
Copy link
Contributor Author

roj234 commented Feb 3, 2026

Current unable to compile on GitHub Actions...

@leejet
Copy link
Owner

leejet commented Feb 4, 2026

This would introduce a dependency on Python. One of the reasons I converted merges/vocab into an .hpp file in advance was precisely to avoid bringing in extra dependencies.

@roj234
Copy link
Contributor Author

roj234 commented Feb 4, 2026

Python is not necessary when compile using C++23, they are only used to re-create those hpps for compilers not support #embed yet (as as fallback), and GitHub Actions have Python installed.
If you don't like to remove those hpps, they can be included via macros.
On my computer, use #embed can save 15 seconds (about 1/3 time when I link to a pre-compiled GGML library). I feel the speedup and a cleaner git history are quite beneficial.
I'm not an expert on CMake and GitHub Actions, so I'm currently struggling with compiler arguments and CI failure.
To finish this PR, I may need to change CMake config and tune some compiler arguments... (However I have never used MSVC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants