Skip to content

Enable MSI signing via SignPath Foundation #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremyfowers merged 11 commits into from
Feb 7, 2026
Merged

Enable MSI signing via SignPath Foundation #909

jeremyfowers merged 11 commits into from
Feb 7, 2026

Conversation

@jeremyfowers
Copy link
Contributor

@jeremyfowers jeremyfowers commented Jan 23, 2026 •
edited
Loading

Closes #908

  • Adds a new CI step for signing MSI installers with a SignPath foundation certificate
  • Updates README and release notes to reflect this
  • IMPORTANT NOTES:
    • Disables self-hosted runner testing during the signed/tagged release flow. This is a SignPath requirement. Just make sure that all tests passed on main on the tagged commit before releasing and we're good.
    • The signing workflow requires someone (me) to manually push "approve" on the SignPath portal - don't forget to do this or the release flow will fail.

@jeremyfowers jeremyfowers self-assigned this Jan 23, 2026
@jeremyfowers jeremyfowers linked an issue Jan 23, 2026 that may be closed by this pull request
Integrate signpath into lemonade release #908
Closed
@jeremyfowers jeremyfowers reopened this Jan 23, 2026
@jeremyfowers jeremyfowers changed the title Enable test signing for signpath in C++ workflow Enable MSI signing via SignPath Foundation Feb 6, 2026
@jeremyfowers jeremyfowers marked this pull request as ready for review February 6, 2026 20:21
ramkrishna2910
ramkrishna2910 reviewed Feb 7, 2026
View reviewed changes
Copy link
Contributor

@ramkrishna2910 ramkrishna2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeremyfowers jeremyfowers added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit 8b07ce8 Feb 7, 2026
59 of 61 checks passed
@jeremyfowers jeremyfowers deleted the 908-integrate-signpath-into-lemonade-release branch February 7, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramkrishna2910 ramkrishna2910 ramkrishna2910 approved these changes

Assignees

@jeremyfowers jeremyfowers

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate signpath into lemonade release

2 participants

@jeremyfowers @ramkrishna2910