New galaxy clusters modeling notebook (based on SMACS J0723.3-7327, Mahler et al. 2023)#41
New galaxy clusters modeling notebook (based on SMACS J0723.3-7327, Mahler et al. 2023)#41jocelyn-mcmahon-16 wants to merge 5 commits intolenstronomy:mainfrom
Conversation
…327 Mahler et al. 2023 data) and the data files needed to run the notebook.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,1965 @@ | |||
| { | |||
There was a problem hiding this comment.
might need more top-level information. Indicate what products are being used for this notebook, perhaps even in what format
Reply via ReviewNB
| @@ -0,0 +1,1965 @@ | |||
| { | |||
There was a problem hiding this comment.
do we still need these descriptions? Try not to duplicate too many feature of another notebook but instead link to that other notebook (easier to maintain fewer information per notebook)
Reply via ReviewNB
| @@ -0,0 +1,1965 @@ | |||
| { | |||
There was a problem hiding this comment.
here I would provide more text, the file name and structure, perhaps even the link to the paper
Reply via ReviewNB
| @@ -0,0 +1,1965 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #33. for i in range(len(gal_data_deg)):
you have many different for-loops here operating on the same part (coordinates). Might be better to do only one for-loop and do all the things at once, perhaps having a definition that does it
Reply via ReviewNB
| @@ -0,0 +1,1965 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #107. # :param center_y: center of halo (in angular units)
do we need all the prints here? It's hard to read it anyways
Reply via ReviewNB
2 participants
Upload of new galaxy clusters modeling notebook based on the work of Mahler et al. 2023 on the SMACS J0723.3-7237. Also added the relevant data files (arcs.dat, galcat.cat, input.par) needed to run the notebook.