Skip to content

macOS: add marketing name#130

Merged
lfreist merged 1 commit intolfreist:mainfrom
Shieldine:main
Oct 29, 2025
Merged

macOS: add marketing name#130
lfreist merged 1 commit intolfreist:mainfrom
Shieldine:main

Conversation

@Shieldine
Copy link
Contributor

This PR adds a lookup function on macOS marketing names.

Apparently, Apple does not expose this name at all (shame on Apple!), so a lookup function is the only way.

@lfreist lfreist merged commit 3b4632c into lfreist:main Oct 29, 2025
6 checks passed
@barracuda156
Copy link
Contributor

@Shieldine Unfortunately, if does not work. Building from 3b4632c I get this:

----------------------------------- OS ------------------------------------
Operating System:    macOS
version:             <unknown> (10K549)
kernel:              Darwin 10.8.0
architecture:        32 bit
endianess:           big endian

With my patch from #125 it was working correctly.

@Shieldine
Copy link
Contributor Author

Shieldine commented Nov 13, 2025

@barracuda156 that's because your version of MacOS can't be determined (version: <unknown>) and the marketing name is derived directly from that version. It'll work once your patch goes through and the version is displayed correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants