default to NONE for PostRedirectFlags#1285
Open
transmissions11 wants to merge 2 commits intolibcpr:masterfrom
Open
default to NONE for PostRedirectFlags#1285transmissions11 wants to merge 2 commits intolibcpr:masterfrom
transmissions11 wants to merge 2 commits intolibcpr:masterfrom
Conversation
matches libcurl default https://curl.se/libcurl/c/CURLOPT_POSTREDIR.html
transmissions11
changed the title
Author
|
ah sorry looks like i'd need to update some tests, if you think you'd be willing to merge i can go ahead and fix them |
COM8
added
the
Breaking Change 🔥
Member
|
@transmissions11 thanks for submitting this! Yes, I'm willing to merge this. We just have to clearly state this change in the changelog when doing the next release. |
Author
|
sorry, missed your reply! tests should be good now — failing ci checks seem unrelated to my patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this unfortunately may be breaking for some users, so if strong backwards compatibility is important maybe wait to include this in a major release or disregard it entirely, but:
both
libcurland python'srequestslibrary do not preserve POST on redirects for 301/302/303 statuses by default (see https://curl.se/libcurl/c/CURLOPT_POSTREDIR.html). this is crucial for various common OAuth/SAML flows which expect GET requests after redirects.given this behavior is the default in other widely-used environments (notably browsers as well), and particularly because cpr aims to be a "spiritual port" of
requests, i believeNONEis a much more sensible default thanPOST_ALL.