Fix error when running CMake configure multiple times with CPR_BUILD_TESTS, bump CMake min version to 3.18#1292
Open
Anohkka wants to merge 1 commit intolibcpr:masterfrom
Open
Fix error when running CMake configure multiple times with CPR_BUILD_TESTS, bump CMake min version to 3.18#1292Anohkka wants to merge 1 commit intolibcpr:masterfrom
Anohkka wants to merge 1 commit intolibcpr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to configure
libcprmultiple times with CPR_BUILD_TESTS currently fails withThe issue is that when we configure the project and call
FetchContent_MakeAvailable(mongoose)for the first time, it works fine because there's no CMakeLists.txt in${mongoose_SOURCE_DIR}, but when attempting to configure the project again, we already copied over our custom CMakeLists.txt to${mongoose_SOURCE_DIR}, soFetchContent_MakeAvailablerunsadd_subdirectorywhich duplicates the target created by our ownadd_subdirectorycall.Setting
SOURCE_SUBDIRto a nonexistent directory preventsFetchContent_MakeAvailablefrom runningadd_subdirectory.SOURCE_SUBDIRwas added in CMake version 3.18, which was released on July 15, 2020.