rcmgr: centralize blocked resource logging through trace reporter#3432
Open
sneaxhuh wants to merge 1 commit intolibp2p:masterfrom
Open
rcmgr: centralize blocked resource logging through trace reporter#3432sneaxhuh wants to merge 1 commit intolibp2p:masterfrom
sneaxhuh wants to merge 1 commit intolibp2p:masterfrom
Conversation
Fixes libp2p#1744 This change consolidates debug logging for blocked resources into a centralized trace reporter system. Previously, debug logs for blocked resources were scattered throughout the codebase and didn't always align with the metrics, which were reliably tracked through trace events. Changes: - Add LogReporter that consumes trace events and logs blocked resources - Remove ad-hoc log.Debug() calls from scope.go - Install LogReporter by default in NewResourceManager - Add tests for LogReporter functionality Benefits: - Logs and metrics now use the same source (trace events) - More maintainable centralized logging approach - Consistent blocked resource reporting
Collaborator
|
This looks good, but we should have this use a parameterized slogger. We can default to the default log in the package as you currently do. We should also have the tests actually verify the log output. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1744
This change consolidates debug logging for blocked resources into a centralized trace reporter system. Previously, debug logs for blocked resources were scattered throughout the codebase and didn't always align with the metrics, which were reliably tracked through trace events.
Changes:
Benefits: