Add UPnP IPv6 pinhole support with keepalive and test tool#3455
Open
prkbuilds wants to merge 1 commit intolibp2p:masterfrom
Open
Add UPnP IPv6 pinhole support with keepalive and test tool#3455prkbuilds wants to merge 1 commit intolibp2p:masterfrom
prkbuilds wants to merge 1 commit intolibp2p:masterfrom
Conversation
Author
|
@MarcoPolo can you guide me if there are any changes that i need make or something I need to revisit? |
MarcoPolo
reviewed
Jan 29, 2026
| github.com/caddyserver/certmagic v0.21.6 | ||
| github.com/gogo/protobuf v1.3.2 | ||
| github.com/google/uuid v1.6.0 | ||
| github.com/ipfs/go-datastore v0.6.0 |
Collaborator
There was a problem hiding this comment.
please backout all the dependency update changes
MarcoPolo
reviewed
Jan 29, 2026
| @@ -0,0 +1,57 @@ | |||
| package main | |||
Collaborator
There was a problem hiding this comment.
Wouldn't it make more sense to use the go-libp2p logic for this?
Collaborator
|
Have you tested this locally with your own router? Can you share your router details? It would help to see if this works with other home router implementations as well, if you could try others and compile a list that would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the problem with v6 stateful routers mentioned in
Summary
Context
This addresses the UPnP AddPinhole approach discussed in #2496 . RFC3633 prefix delegation is intentionally out of scope in this PR.
Usage
Opt‑in via:
AI Assistance
AI assistance used to draft and refine the implementation over my direction.
My thinking / direction
Question
Is this direction OK, and should I proceed with additional work (e.g., RFC3633 exploration, more robust address change handling, or optional auto‑enable)?