Skip to content

refactor: remove dead supported_protocols field from swarm #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Forostovec wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −13
Open

refactor: remove dead supported_protocols field from swarm #6265

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46ba769
refactor: remove dead supported_protocols field from swarm
Forostovec Feb 4, 2026
1ef832e
unused import
Forostovec Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions swarm/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ use tracing::Instrument;
#[doc(hidden)]
pub use translation::_address_translation;

use crate::{behaviour::ExternalAddrConfirmed, handler::UpgradeInfoSend};
use crate::behaviour::ExternalAddrConfirmed;

/// Event generated by the [`NetworkBehaviour`] that the swarm will report back.
type TBehaviourOutEvent<TBehaviour> = <TBehaviour as NetworkBehaviour>::ToSwarm;
Expand Down Expand Up @@ -323,9 +323,6 @@ where
/// handlers.
behaviour: TBehaviour,

/// List of protocols that the behaviour says it supports.
supported_protocols: SmallVec<[Vec<u8>; 16]>,

confirmed_external_addr: HashSet<Multiaddr>,

/// Multiaddresses that our listeners are listening on,
Expand Down Expand Up @@ -360,7 +357,6 @@ where
transport,
pool: Pool::new(local_peer_id, config.pool_config),
behaviour,
supported_protocols: Default::default(),
confirmed_external_addr: Default::default(),
listened_addrs: HashMap::new(),
pending_handler_event: None,
Expand Down Expand Up @@ -766,13 +762,6 @@ where
}
}
};

let supported_protocols = handler
.listen_protocol()
.upgrade()
.protocol_info()
.map(|p| p.as_ref().as_bytes().to_vec())
.collect();
let other_established_connection_ids = self
.pool
.iter_established_connections_of_peer(&peer_id)
Expand Down Expand Up @@ -810,7 +799,6 @@ where
other_established: other_established_connection_ids.len(),
},
));
self.supported_protocols = supported_protocols;
self.pending_swarm_events
.push_back(SwarmEvent::ConnectionEstablished {
peer_id,
Expand Down
Loading