refactor: remove dead supported_protocols field from swarm#6265
Open
Forostovec wants to merge 2 commits intolibp2p:masterfrom
Open
refactor: remove dead supported_protocols field from swarm#6265Forostovec wants to merge 2 commits intolibp2p:masterfrom
Forostovec wants to merge 2 commits intolibp2p:masterfrom
Conversation
elenaf9
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this change Swarm kept a supported_protocols SmallVec that was written on every connection establishment but never read. This caused unnecessary allocations and extra work without affecting behaviour.
This change removes the unused supported_protocols field from Swarm, its initialization in the constructor, and the redundant computation/assignment in handle_pool_event, keeping all connection-level protocol tracking logic unchanged.