Removed logging check that was causing dependency fetching to fail#3009
Open
DanBeard wants to merge 2 commits intolibrariesio:mainfrom
Open
Removed logging check that was causing dependency fetching to fail#3009DanBeard wants to merge 2 commits intolibrariesio:mainfrom
DanBeard wants to merge 2 commits intolibrariesio:mainfrom
Conversation
tiegz
reviewed
Oct 3, 2022
Co-authored-by: Tieg Zaharia <tieg.zaharia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks taking the time to contribute. This template should help guide you through the process of creating a pull request for review. Please erase any part of this template that is not relevant to your pull request:
Quick fix for #3008 . source_info is nil since Pypi removed
$["releases"]from the JSON API response. Commenting out this line stops the error from being thrown and allows dependencies to be grabbed for projects in my local env.Unsure when the Pypi API was actually changed. Recent Pypi packages may need to be re-evaluated to ensure dependency information in libraries,io is correct.