Skip to content

Multisite compatibility#151

Merged
k1sul1 merged 11 commits intofeature/2.0from
fix/multisite
May 31, 2019
Merged

Multisite compatibility#151
k1sul1 merged 11 commits intofeature/2.0from
fix/multisite

Conversation

@k1sul1
Copy link
Member

@k1sul1 k1sul1 commented Jan 27, 2019

#105

This is starting to look unfixable without resorting in brittle hacks. I looked at how Unfiltered MU does it, and it's complicated. AFAIK there's no way to add the unfiltered_html cap to a single post type only that would always work.

Checking that the user is posting data from wplf-form is tricky to do in admin, and then there's the case of /wp-json/wp/v2/wplf-form. Removing the cap after save could cause some problems if someone has added the cap previously.

I'd say we block users that are not super admins from editing forms, unless they have the cap, and document this in the README, along the lines of

Multisite support

WP Libre Form works fine in WordPress Network (multisite). There's some gotchas:

  • Plugin must be activated in each site, not on network level
  • Only Super Admins can edit forms.
    • This is because Network strips dangerous input like iframes & input fields from the content.
    • Can be worked around by installing Unfiltered MU

@k1sul1 k1sul1 self-assigned this Jan 27, 2019
@k1sul1 k1sul1 force-pushed the fix/multisite branch 2 times, most recently from bd38b72 to f8aa7e8 Compare January 27, 2019 18:10
@k1sul1 k1sul1 changed the title Fix #105 [WIP] Multisite compatibility Jan 27, 2019
@k1sul1 k1sul1 added this to the 2.0 milestone Jan 27, 2019
@k1sul1 k1sul1 changed the base branch from master to feature/2.0 May 31, 2019 06:54
@k1sul1 k1sul1 merged commit 7a1a6a0 into feature/2.0 May 31, 2019
@k1sul1 k1sul1 deleted the fix/multisite branch May 31, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants