Conversation
bd38b72 to
f8aa7e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#105
This is starting to look unfixable without resorting in brittle hacks. I looked at how Unfiltered MU does it, and it's complicated. AFAIK there's no way to add the unfiltered_html cap to a single post type only that would always work.
Checking that the user is posting data from wplf-form is tricky to do in admin, and then there's the case of /wp-json/wp/v2/wplf-form. Removing the cap after save could cause some problems if someone has added the cap previously.
I'd say we block users that are not super admins from editing forms, unless they have the cap, and document this in the README, along the lines of
Multisite support
WP Libre Form works fine in WordPress Network (multisite). There's some gotchas: