Create default settings file, and ignore used file#238
Open
Dubz wants to merge 1 commit intolibrespeed:masterfrom
Open
Create default settings file, and ignore used file#238Dubz wants to merge 1 commit intolibrespeed:masterfrom
Dubz wants to merge 1 commit intolibrespeed:masterfrom
Conversation
This changes the settings file name, and adds an entry to gitignore to ignore the used file name. This will avoid any issues pulling updates to a live environment with a modified settings file.
Member
|
That's actually not a bad idea. I'll merge this with the next major release (I need to update the video tutorial) |
Author
Sounds good! You may want to consider merging the ./backend/getIP_ipInfo_apikey.php file with it as well, and any other similar files. I'm sure people run into the same issue if they utilize that too. |
Member
|
Yes, I was thinking the same thing |
|
Seeing as there are conflicts here, has this been merged? |
Member
|
@flying-sausages No, but this concept will certainly be included in the next release. I was planning it for 2020 but I've had too many things to do so I haven't done any real work on LS in a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the settings file name, and adds an entry to gitignore to ignore the used file name.
This will avoid any issues pulling updates to a live environment with a modified settings file.