Support 64bit MP_DIGIT on Windows under clang-cl#592
Open
R-Goc wants to merge 1 commit intolibtom:developfrom
Open
Support 64bit MP_DIGIT on Windows under clang-cl#592R-Goc wants to merge 1 commit intolibtom:developfrom
R-Goc wants to merge 1 commit intolibtom:developfrom
Conversation
Author
|
This also allows for building a debug version with clang-cl. I couldn't get it to happen with msvc. As in if I did the things required for it it is no longer a debug build as it would require at least turning off real time checks (/RTC1 passed by cmake) which defeats the purpose of a debug build. Maybe I am missing something here. |
This commit make MP_DIGIT 64 bit when using clang-cl. It also explicitly sets compile flags for clang-cl.
Author
|
My only concern is what happens if tommath is compiled with msvc but the consumer uses clang-cl. At that point everything will break I am afraid. Is MP_WORD anywhere in the ABI of the library? If so then that could also cause issues as __int128 is not stable in the msvc ABI and afaik not even defined. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit make MP_DIGIT 64 bit when using clang-cl. It also explicitly sets compile flags for clang-cl.