Skip to content

Open source a generic http client module to garr#6

Open
Permagate wants to merge 1 commit intomainfrom
add_httpclient_module
Open

Open source a generic http client module to garr#6
Permagate wants to merge 1 commit intomainfrom
add_httpclient_module

Conversation

@Permagate
Copy link
Collaborator

@Permagate Permagate commented Apr 15, 2022 •
edited
Loading

  • Copy module to garr.
  • Adapt changes to open source.
    • Add apache license.
    • Update module name to a generic httpclient.
    • Update some imports to go.linecorp.com/garr.
    • Update tests to use only go standard test package.
  • Fix data race.
  • Create readme and examples.

@Permagate Permagate self-assigned this Apr 15, 2022
@Permagate Permagate added wip This pull request is still being worked on, not safe to merge yet enhancement New feature or request labels Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linxGnu linxGnu Awaiting requested review from linxGnu

@unrealhoang unrealhoang Awaiting requested review from unrealhoang

@BlaCkinkGJ BlaCkinkGJ Awaiting requested review from BlaCkinkGJ BlaCkinkGJ is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Permagate Permagate

Labels

enhancement New feature or request wip This pull request is still being worked on, not safe to merge yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Permagate