-
Notifications
You must be signed in to change notification settings - Fork 834
fix: add zod as an external depth #1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a changeset file announcing a patch release for lingo.dev and related packages and reorders existing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Summary
Fixes runtime errors from multiple Zod instances by marking
zodas external in the CLI, spec, and compiler builds so a single Zod instance is used.Changes
"zod"toexternalso the CLI does not bundle Zod.external: ["zod"]so the spec does not bundle Zod.external: ["zod"]so the compiler does not bundle Zod.lingo.dev,@lingo.dev/_spec,@lingo.dev/_compiler, and@lingo.dev/_sdkvia changesets.Testing
Business logic tests added:
lingo.dev run --bucket json; noreading 'run'or_parseSync is not a function.Visuals
Required for UI/UX changes:
Checklist
Closes #--
Summary by CodeRabbit