Open
Conversation
Previously, the tracing integration test only checked for a simple existence of a trace with a service name, while not inspecting the actual values inside the trace. This makes the test check the tags inside a specific trace, both for a process and a span. In the future, this can be improved even more to inspect all spans in a trace and ensure the relationships between them are correct, but this will require updates to emojivoto and its propagation to be viable. Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
force-pushed
the
sfleen/trace-test-better
branch
from
ea2bf41 to
e5d3a1e
Compare
adleong
reviewed
Nov 17, 2025
|
|
||
| func (_ anyMatcher) assertMatches(_ *testing.T, _ string, _ interface{}) {} | ||
|
|
||
| func inspectTraces(t *testing.T, traces *traces, expected expectedTrace) error { |
Member
There was a problem hiding this comment.
personal preference, but I find nested loops that include a mix of breaks and continues to be very hard to follow and reason about. consider splitting this into smaller functions with clear semantics and using return for control flow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the tracing integration test only checked for a simple existence of a trace with a service name, while not inspecting the actual values inside the trace.
This makes the test check the tags inside a specific trace, both for a process and a span.
In the future, this can be improved even more to inspect all spans in a trace and ensure the relationships between them are correct, but this will require updates to emojivoto and its propagation to be viable.