Skip to content

[fix] swap the dash with an underscore for the karpenter CRD chart since chart-releaser doesn't seem to like the dash in the chart name#71

Closed
AshleyDumaine wants to merge 1 commit intomainfrom
chart-releaser-fix
Closed

[fix] swap the dash with an underscore for the karpenter CRD chart since chart-releaser doesn't seem to like the dash in the chart name#71
AshleyDumaine wants to merge 1 commit intomainfrom
chart-releaser-fix

Conversation

@AshleyDumaine
Copy link
Contributor

What this PR does / why we need it: The chart-releaser (which the chart-releaser-action uses) doesn't seem to play nicely with charts that have a dash in the name for trying to extract the name and version: https://github.com/helm/chart-releaser/blob/v1.7.0/pkg/releaser/releaser.go#L253-L256

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

…art-releaser doesn't seem to like the dash in the chart name
@eljohnson92 eljohnson92 self-requested a review February 10, 2026 18:33
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.00%. Comparing base (981c3d4) to head (daf4bee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files          37       37           
  Lines        2631     2631           
=======================================
  Hits         1763     1763           
  Misses        554      554           
  Partials      314      314           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine deleted the chart-releaser-fix branch February 10, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants