[fix] swap the dash with an underscore for the karpenter CRD chart since chart-releaser doesn't seem to like the dash in the chart name#71
Closed
AshleyDumaine wants to merge 1 commit intomainfrom
Closed
Conversation
…art-releaser doesn't seem to like the dash in the chart name
eljohnson92
approved these changes
Feb 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=======================================
Coverage 67.00% 67.00%
=======================================
Files 37 37
Lines 2631 2631
=======================================
Hits 1763 1763
Misses 554 554
Partials 314 314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The chart-releaser (which the chart-releaser-action uses) doesn't seem to play nicely with charts that have a dash in the name for trying to extract the name and version: https://github.com/helm/chart-releaser/blob/v1.7.0/pkg/releaser/releaser.go#L253-L256
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: