Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for NetLoadBalancer endpoints, including operations for load balancers, listeners, and nodes. The implementation includes unit tests for CRUD operations, JSON unmarshaling, edge cases, and conversion methods.
- Adds unit tests for NetLoadBalancer, NetLoadBalancerListener, and NetLoadBalancerNode endpoints
- Implements JSON fixtures to support the test cases
- Includes tests for helper methods (GetCreateOptions, GetUpdateOptions)
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/netloadbalancer_test.go | Tests for NetLoadBalancer CRUD operations, JSON unmarshaling, and conversion methods |
| test/unit/netloadbalancer_listeners_test.go | Tests for listener CRUD operations, node weight updates, and edge cases |
| test/unit/netloadbalancer_nodes_test.go | Tests for node CRUD operations, conversion methods, and edge cases |
| test/unit/fixtures/*.json | JSON fixtures supporting various test scenarios for load balancers, listeners, and nodes |
| netloadbalancer.go | Core NetLoadBalancer struct and API methods |
| netloadbalancer_listeners.go | NetLoadBalancerListener struct and API methods |
| netloadbalancer_nodes.go | NetLoadBalancerNode struct and API methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zliang-akamai
approved these changes
Nov 26, 2025
vshanthe
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
linode-load-balancer-controller requires nlb-endpoints implemented by linodego. We want to move from our fork to main branch.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.