Ensure parity for region capability consts#886
Open
dawiddzhafarov wants to merge 1 commit intolinode:mainfrom
Open
Ensure parity for region capability consts#886dawiddzhafarov wants to merge 1 commit intolinode:mainfrom
dawiddzhafarov wants to merge 1 commit intolinode:mainfrom
Conversation
dawiddzhafarov
requested review from
a team,
Copilot,
ezilber-akamai,
jriddle-linode,
lgarber-akamai and
zliang-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes region capability constants with the upstream linodego library by adding missing capabilities and removing deprecated ones to maintain parity.
Changes:
- Added 20 new region capability constants that were present in linodego but missing from this file
- Removed deprecated
CapabilityBareMetalconstant - Reordered constants alphabetically for better maintainability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CapabilityMachineImages string = "Machine Images" | ||
| CapabilityMaintenancePolicy string = "Maintenance Policy" | ||
| CapabilityMetadata string = "Metadata" | ||
| CapabilityNLB string = "Network LoadBalancer" |
There was a problem hiding this comment.
Corrected spelling of 'LoadBalancer' to 'Load Balancer' (two words) to match standard terminology and other capability names.
Suggested change
| CapabilityNLB string = "Network LoadBalancer" | |
| CapabilityNLB string = "Network Load Balancer" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds consts that are listed here but were not present in
regions.go.CapabilityBareMetalhas been removed as it's no longer listed in the above file.✔️ How to Test
make test-unit