upcoming: [UIE-9746] - Implement Remove Lock Modal. by tanushree-akamai · Pull Request #13348 · linode/manager

tanushree-akamai · 2026-01-30T13:36:37Z

Description 📝

This PR implements the Remove Lock modal accessible from the Linode action menu.

Changes 🔄

List any change(s) relevant to the reviewer.

Implemented Remove lock dialog
Integrated Remove lock dialog with the Unlock option in Linode action menu
Implemented unit tests for the Remove lock dialog
Implemented unit tests for Linode action menu

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Preview 📷

Linode Landing behavior:
https://github.com/user-attachments/assets/4c30fd4e-e67b-41f0-8faf-382842b1d40a

Linode Detail behavior:
https://github.com/user-attachments/assets/14378fa7-fd78-4853-8c47-b364f5997657

Remove Modal when lock type is 'cannot_delete'

Remove Modal when lock type is 'cannot_delete_with_subresources'

How to test 🧪

Reproduction steps

Verification steps

Navigate to /linodes
Click on Linode action menu and select Unlock
Verify Remove Lock Dialog launches
Verify notification toast on success
Verify notification on error
⚠️ This is a temporary workaround for testing only
Since IAM permissions for Resource Locks are not fully implemented yet, you can temporarily bypass the permission checks to validate the Lock/Unlock behavior with real API data.
Comment the permission checks on line 247 in LinodeActionMenu.tsx:

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

Copilot

Pull request overview

This PR implements the Remove Lock modal functionality, enabling users to unlock Linodes from the action menu. The implementation includes UI components, integration with the Linode action menu, and comprehensive unit test coverage.

Changes:

Created RemoveLockDialog component with lock type-specific messaging
Integrated unlock functionality into Linode action menus (landing and detail pages)
Added unit tests for RemoveLockDialog and LinodeActionMenu lock/unlock actions

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
RemoveLockDialog.tsx	New dialog component for removing locks with API integration
RemoveLockDialog.test.tsx	Comprehensive unit tests for the remove lock dialog
LinodeActionMenu.tsx	Updated to trigger remove lock dialog and renamed locks prop
LinodeActionMenu.test.tsx	Added tests for lock/unlock action visibility and permissions
LinodesLanding.tsx	Added state management and dialog integration for remove lock
ListView.tsx	Threaded remove lock handler through to LinodeRow components
CardView.tsx	Added remove lock handler to card view rendering
DisplayLinodes.tsx	Added openRemoveLockDialog prop to interface definitions
DisplayGroupedLinodes.tsx	Added openRemoveLockDialog prop to interface definitions
LinodeRow.tsx	Renamed locks prop to linodeLocks for consistency
LinodeRow.test.tsx	Added onOpenRemoveLockDialog to test props
LinodeDetailHeader.tsx	Added remove lock dialog state and integration
LinodeEntityDetailHeader.tsx	Added linodeLocks prop to header interface
LinodeEntityDetail.tsx	Passed linodeLocks to entity detail header
EntityHeader.stories.tsx	Added linodeLocks prop to storybook examples
EntityDetail.stories.tsx	Added onOpenRemoveLockDialog to storybook examples
.changeset file	Added changeset entry for the feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-30T13:46:45Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/RemoveLockDialog.tsx

+      const locksResponse = await getLocks(
+        {},
+        {
+          '+and': [{ 'entity.id': linodeId }, { 'entity.type': 'linode' }],
+        }
+      );


The error message 'No lock found for this Linode.' is ambiguous when getLocks returns an empty array. This could mean the lock was already removed, or there was never a lock. Consider a more specific error message like 'No active lock found. It may have already been removed.' to better inform users.

Copilot · 2026-01-30T13:46:45Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/RemoveLockDialog.tsx

+        }
+      );
+
+      const lock = locksResponse.data[0];


Assuming only the first lock needs to be deleted when multiple locks might exist. If a Linode can have multiple locks, this implementation will only remove the first one. Consider either removing all locks returned by the query or documenting why only the first lock is targeted.

Agreed.

Long term, should we delete all locks on the Linode? Or is this just temporary untill we let the user select which lock to delete.

const deleteLockRequests = locksResponse.data.map((lock) => deleteLock(lock.id) ); await Promise.all(deleteLockRequests);

If (and when) we have multiple locks - we would enhance the UI to explicitly ask for which lock users would like to remove. I have added inline for clarity: ed7bebd

bnussman-akamai · 2026-01-30T17:46:53Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/RemoveLockDialog.tsx

+        }
+      );
+
+      const lock = locksResponse.data[0];


Agreed.

Long term, should we delete all locks on the Linode? Or is this just temporary untill we let the user select which lock to delete.

const deleteLockRequests = locksResponse.data.map((lock) => deleteLock(lock.id) ); await Promise.all(deleteLockRequests);

bnussman-akamai · 2026-01-30T17:48:29Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/RemoveLockDialog.tsx

+    }
+  }, [open]);
+
+  const handleSubmit = async () => {


Rather than managing isLoading and error manually, we could use React Query to simplify things

For example:

import { useMutation } from '@tanstack/react-query'; const { mutate, isPending, error } = useMutation<{}, APIError[]>({ mutationFn: async () => { const locksResponse = await getLocks( {}, { 'entity.id': linodeId, 'entity.type': 'linode', } ); const deleteLockRequests = locksResponse.data.map((lock) => deleteLock(lock.id) ); await Promise.all(deleteLockRequests); return {}; }, onSuccess() { enqueueSnackbar(`Lock removed from ${linodeLabel}.`, { variant: 'success', }); onClose(); }, });

Addressed in ed7bebd

bnussman-akamai · 2026-01-30T17:50:59Z

packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.test.tsx

+      queryMocks.useFlags.mockReturnValue({
+        resourceLock: { linodes: false },
+      });
+
+      const { getByLabelText, queryByText } = renderWithTheme(
+        <LinodeActionMenu {...props} />
+      );


Rather than mocking the use src/hooks/useFlags module, we should use our buit in flags helper if possible

Suggested change

queryMocks.useFlags.mockReturnValue({

resourceLock: { linodes: false },

});

const { getByLabelText, queryByText } = renderWithTheme(

<LinodeActionMenu {...props} />

);

const { getByLabelText, getByText } = renderWithTheme(

<LinodeActionMenu {...props} linodeLocks={[]} />,

{ flags: { resourceLock: { linodes: true } }}

);

Addressed in ed7bebd

packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/RemoveLockDialog.test.tsx

grevanak-akamai · 2026-02-03T12:13:06Z

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

❌ Failing ✅ Passing ↪️ Skipped 🕐 Duration
4 Failing 861 Passing 11 Skipped 55m 15s

Details

Failing Tests
Spec Test
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Image
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Community StackScript
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Account StackScript
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » can rebuild a linode with the GECKO is enabled

Troubleshooting

Use this command to re-run the failing tests:
pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts"

@tanushree-akamai , not sure why they are failing but can you take a look?

bnussman-akamai · 2026-02-03T17:03:07Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/RemoveLockDialog.tsx

+      const locks = locksResponse.data;
+
+      if (locks.length === 0) {
+        throw [{ reason: 'No active lock found for this Linode.' }];


Maybe we can use Promise.reject to address the eslint warning here.

Suggested change

throw [{ reason: 'No active lock found for this Linode.' }];

return Promise.reject([

{ reason: 'No active lock found for this Linode.' },

]);

Addressed in 57886bd

cliu-akamai · 2026-02-03T18:55:08Z

Hi @tanushree-akamai, I think I found the culprit. When you rebuild a linode from the Linode details page, the request will not include linodeLocks values. In addition, the code here doesn't check that, which will cause an error, leading to this page:

So that's why it failed the tests.

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

❌ Failing ✅ Passing ↪️ Skipped 🕐 Duration
4 Failing 861 Passing 11 Skipped 55m 15s

Details

Failing Tests
Spec Test
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Image
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Community StackScript
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » rebuilds a linode from Account StackScript
❌ rebuild-linode.spec.ts Cloud Manager Cypress Tests→rebuild linode » can rebuild a linode with the GECKO is enabled

Troubleshooting

Use this command to re-run the failing tests:
pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts"
@tanushree-akamai , not sure why they are failing but can you take a look?

…linodes.

linode-gh-bot · 2026-02-05T11:24:11Z

Cloud Manager UI test results

🎉 866 passing tests on test run #9 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`0 Failing`	`866 Passing`	`11 Skipped`	`36m 59s`

tanushree-akamai requested a review from a team as a code owner January 30, 2026 13:36

tanushree-akamai added Ready for Review RESPROT-2 Resource Locking labels Jan 30, 2026

github-project-automation bot moved this to Review in Cloud Manager Jan 30, 2026

github-project-automation bot added this to Cloud Manager Jan 30, 2026

tanushree-akamai requested review from bnussman-akamai, Copilot and grevanak-akamai and removed request for a team January 30, 2026 13:36

Copilot AI reviewed Jan 30, 2026

View reviewed changes

bnussman-akamai reviewed Jan 30, 2026

View reviewed changes

grevanak-akamai reviewed Feb 2, 2026

View reviewed changes

packages/manager/src/features/Linodes/LinodesDetail/LinodeLock/RemoveLockDialog.test.tsx Outdated Show resolved Hide resolved

tanushree-akamai requested a review from bnussman-akamai February 2, 2026 18:11

tanushree-akamai force-pushed the feature/UIE-9746-resprot2-remove-lock-modal branch from ed7bebd to 0e9cfa4 Compare February 2, 2026 18:22

bnussman-akamai approved these changes Feb 3, 2026

View reviewed changes

tanushree-akamai added 6 commits February 5, 2026 14:17

upcoming: [UIE-9746] - Implement Remove Lock Modal.

e11af5c

Added changeset: Implemented Remove Lock Dialog from Linode Action Menu

e323f1b

Address review comments.

7041fbd

Address review comments.

80df85d

Fix e2e test cases related to reuild.

d29b56a

Fix Remove lock dialog error handling and refreshing query cache for …

1113318

…linodes.

tanushree-akamai force-pushed the feature/UIE-9746-resprot2-remove-lock-modal branch from 7796324 to 1113318 Compare February 5, 2026 08:47

-        throw [{ reason: 'No active lock found for this Linode.' }];
+        return Promise.reject([
+          { reason: 'No active lock found for this Linode.' },
+        ]);

Conversation

tanushree-akamai commented Jan 30, 2026

Description 📝

Changes 🔄

Scope 🚢

Preview 📷

How to test 🧪

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tanushree-akamai Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tanushree-akamai Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

tanushree-akamai Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

grevanak-akamai commented Feb 3, 2026

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

Details

Troubleshooting

Uh oh!

bnussman-akamai Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

tanushree-akamai Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

cliu-akamai commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cloud Manager UI test results

🔺 4 failing tests on test run #4 ↗︎

Details

Troubleshooting

Uh oh!

linode-gh-bot commented Feb 5, 2026

Cloud Manager UI test results

🎉 866 passing tests on test run #9 ↗︎

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bnussman-akamai Jan 30, 2026 •

edited

Loading

bnussman-akamai Jan 30, 2026 •

edited

Loading

bnussman-akamai Jan 30, 2026 •

edited

Loading

cliu-akamai commented Feb 3, 2026 •

edited

Loading