Add: [DI-29170] - Value field selection limitation in CloudPulse metrics and alerts dimension filters#13361
Open
venkymano-akamai wants to merge 14 commits intolinode:developfrom
Open
Conversation
…mano-akamai/manager into value_field_dimension_filter_limit
…mano-akamai/manager into value_field_dimension_filter_limit
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to restrict the maximum number of selectable values in CloudPulse metrics and alerts dimension filters, controlled by a feature flag.
Changes:
- Added
maxDimensionFiltersValuesfeature flag to control selection limits - Implemented UI restrictions that disable options once the limit is reached and hide select/deselect all buttons when appropriate
- Added validation schema to enforce the maximum selection limit for the 'in' operator
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| featureFlags.ts | Added maxDimensionFiltersValues property to AclpAlerting interface |
| CloudPulseDimensionFilterRenderer.tsx | Passed feature flag value to form context for validation |
| CloudPulseDimensionFilterFields.tsx | Replaced setValue with resetField to properly reset form state |
| EditAlertDefinition.tsx | Added feature flag to form context for alert editing |
| utils.ts | Added helper functions to check max selections and determine option disabled state |
| utils.test.ts | Added comprehensive test coverage for new helper functions |
| ValueSchemas.ts | Added validation for 'in' operator to enforce max selection limit |
| ValueFieldRenderer.tsx | Retrieved feature flag and passed maxSelections to autocomplete components |
| [Multiple Autocomplete files] | Integrated max selection logic including helper text, disabled options, and select all control |
| constants.ts | Added maxSelections property to DimensionFilterAutocompleteProps interface |
| .changeset/pr-13361-added-1770207290291.md | Added changeset documenting the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...nager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/utils.test.ts
Outdated
Show resolved
Hide resolved
...nager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/utils.test.ts
Outdated
Show resolved
Hide resolved
...ger/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/ValueSchemas.ts
Show resolved
Hide resolved
santoshp210-akamai
approved these changes
Feb 5, 2026
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #12 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts" |
|||||||||||||||||
kmuddapo
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Ability to restrict the maximum selectable values in the CloudPulse metrics and alerts dimension filters.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️ Next Release date
Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅