-
Notifications
You must be signed in to change notification settings - Fork 110
Support ACLP Alert Definition Resource and Data Sources #2234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for ACLP (Akamai Cloud Linode Platform) Monitor Alert Definition resources and data sources to the Terraform provider, enabling users to manage and query alert definitions for monitoring services.
Changes:
- Added resource and data sources for managing monitor alert definitions
- Implemented template-based test fixtures for alert definitions and channels
- Updated dependency versions and provider registration
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| linode/monitoralertdefinition/framework_resource.go | Implements the core CRUD operations for alert definition resource |
| linode/monitoralertdefinition/framework_models.go | Defines data models and flattening logic for alert definitions |
| linode/monitoralertdefinition/framework_resource_schema.go | Defines the Terraform schema for alert definition resource |
| linode/monitoralertdefinitions/framework_datasource.go | Implements data source for listing alert definitions |
| linode/monitoralertdefinitions/framework_models.go | Defines models for alert definitions data source |
| linode/monitoralertdefinition/resource_test.go | Integration tests for alert definition resource |
| linode/monitoralertdefinitions/datasource_test.go | Integration tests for alert definitions data source |
| linode/monitoralertdefinition/datasource_test.go | Integration tests for single alert definition data source |
| linode/helper/framework_data.go | Adds helper function for Float64 type handling |
| linode/framework_provider.go | Registers new resources and data sources |
| docs/resources/monitor_alert_definition.md | Documentation for alert definition resource |
| docs/data-sources/monitor_alert_definition.md | Documentation for single alert definition data source |
| docs/data-sources/monitor_alert_definitions.md | Documentation for alert definitions data source |
| go.mod | Updates dependencies and adds linodego replace directive |
Comments suppressed due to low confidence (1)
linode/monitoralertdefinition/tmpl/basic.gotf:1
- Corrected spelling of 'ansible' reference in description to be consistent with actual test purpose.
{{ define "alert_definition_basic" }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 Description
This PR adds support to ACLP alert definition.
Depends on linode/linodego#878. Will need to review and merge the linodego PR first.
✔️ How to Test
Unit test:
Integration test: