Skip to content

Comments

fix: Fail on unsupported architectures#30

Merged
spetrosi merged 1 commit intolinux-system-roles:mainfrom
spetrosi:skip-archs
Oct 13, 2025
Merged

fix: Fail on unsupported architectures#30
spetrosi merged 1 commit intolinux-system-roles:mainfrom
spetrosi:skip-archs

Conversation

@spetrosi
Copy link
Collaborator

@spetrosi spetrosi commented Oct 13, 2025

Enhancement: This role supports the x86_64 architecture only

Summary by Sourcery

Enforce x86_64-only support by failing on other architectures, update documentation accordingly, and skip tests for unsupported architectures

Enhancements:

  • Add fail task in main role to abort on non-x86_64 architectures
  • Update README to declare x86_64 as the only supported architecture

Documentation:

  • Document x86_64-only restriction in the README

Tests:

  • Introduce skip_unsupported_archs.yml to halt tests on unsupported architectures
  • Include skip logic in all test playbooks to bypass non-x86_64 hosts

This role supports the x86_64 architecture only
@spetrosi spetrosi requested a review from richm as a code owner October 13, 2025 10:36
@sourcery-ai
Copy link

sourcery-ai bot commented Oct 13, 2025

Reviewer's Guide

Enforce x86_64-only support by failing early on unsupported architectures in the main role, centralizing skip logic for test suites, updating all tests to include this skip, and documenting the constraint in the README.

Sequence diagram for architecture check and failure in main role

sequenceDiagram
    participant Ansible
    participant "tasks/main.yml"
    Ansible->>"tasks/main.yml": Start role execution
    "tasks/main.yml"->>"tasks/main.yml": Check ansible_architecture
    alt Architecture is x86_64
        "tasks/main.yml"->>"tasks/main.yml": Continue role execution
    else Architecture is not x86_64
        "tasks/main.yml"->>Ansible: Fail with message
    end
Loading

File-Level Changes

Change Details Files
Fail immediately on non-x86_64 platforms
  • Inserted a failure task in tasks/main.yml that triggers when ansible_architecture != 'x86_64'
  • Crafted a clear error message indicating the detected architecture
tasks/main.yml
Integrate skip logic into all test playbooks
  • Added include_tasks for skip_unsupported_archs.yml at the top of each test file
  • Tagged the reboot test in tests_skip_toolkit.yml for clarity
tests/tests_skip_toolkit.yml
tests/tests_default.yml
tests/tests_include_vars_from_parent.yml
Add centralized skip_unsupported_archs.yml task file
  • Gather architecture facts with setup gather_subset
  • End the host early via meta when arch != 'x86_64'
tests/tasks/skip_unsupported_archs.yml
Document x86_64-only support in README
  • Added a note under Requirements stating the role only supports x86_64
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@spetrosi
Copy link
Collaborator Author

[citest]

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@spetrosi spetrosi merged commit e85e877 into linux-system-roles:main Oct 13, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant