Fix usable dimensions of the XP-PEN Artist 22R and 24 Pro#896
Merged
whot merged 1 commit intolinuxwacom:masterfrom Aug 3, 2025
Merged
Conversation
I didn't realize at the time that properties are supposed to be the usable area, *not* the physical dimensions of the device. Because linuxwacom#864 is not here yet, I rounded up for these.
Member
|
thx, merging. fwiw, doesn't matter since afaik nothing actually uses those values |
Contributor
Author
Indeed, I realized that right after making the PR that libinput calculates it a different way! |
Member
libinput gets it from the absinfo min/max and resolution (one reason why we need resolution for tablets btw). you can also get it from udev via ID_INPUT_WIDTH_MM and ID_INPUT_HEIGHT_MM but that property may be wrong if we have evdev overrides in place (rare enough for tablets at least) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't realize at the time that properties are supposed to be the usable area, not the physical dimensions of the device. Because #864 is not here yet, I rounded up for these.