Conversation
distantorigin
left a comment
distantorigin
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Great to see work done towards dockerizing the server.
Before I merge your additions, can you please review my requested changes below?
- Ubuntu has a virtual package for Libargon2; the build step can be removed.
- Server ports should be configurable.
- Consider making an env file for core database (CORE_TO_LOAD), port, and other potential values that may be changed.
Dockerfile
Outdated
| RUN ls /toaststunt/CMakeModules | ||
|
|
||
|
|
||
| # PRE ARGON BUILD |
There was a problem hiding this comment.
Ubuntu 20.10 has a virtual package for Libargon2 - building is not required. (In retrospect, the project readme should also be updated to reflect this.)
Dockerfile
Outdated
|
|
||
| COPY CMakeLists.txt /toaststunt/ | ||
| COPY CMakeModules /toaststunt/CMakeModules | ||
| RUN ls /toaststunt/CMakeModules |
There was a problem hiding this comment.
This seems to be left over debugging - can we remove?
| image: toaststunt:2.7.0_10 | ||
| build: | ||
| context: . | ||
| ports: |
There was a problem hiding this comment.
Server port should be configurable via environment variables.
There was a problem hiding this comment.
Server port can be re-mapped outside container using the ports syntax.
See comments in the new commit ea4ca08
docker-compose.yml
Outdated
| context: . | ||
| ports: | ||
| - 7777:7777 | ||
| - 8888:8888 |
There was a problem hiding this comment.
Consider removing this extra port - see above [line 8].
libargon is already installed Co-authored-by: distantorigin <tbussiere@icloud.com>
Removed debug code Explained how to change mapped port
|
Added modification as requested. |
2 participants
Hi,
I am very happy to see an evolving Moo out of there :)
I was working on a plain Lambdamoo and I added docker support.
So I ported it to this version :)
Have a nice day!