Skip to content

Conversation

@peternewman
Copy link

@peternewman peternewman commented Jun 24, 2021

@liskin
Copy link
Owner

liskin commented Jun 26, 2021

The jsons here are intentionally indented by jq, even though it means divergence from the original source.

(I'll look at your other PRs once I get back from vacation in a couple weeks.)

@peternewman
Copy link
Author

The jsons here are intentionally indented by jq, even though it means divergence from the original source.

Ah fair enough. Where I started with this, when I saw it differ, was wondering if it was out of date. Maybe this should be a separate issue, but it would be good if there was a system or process to keep these files in sync (Git submodules or just wget or whatever).

(I'll look at your other PRs once I get back from vacation in a couple weeks.)

Thanks, no real rush.

@liskin
Copy link
Owner

liskin commented Jul 13, 2021

it would be good if there was a system or process to keep these files in sync

That would be nice indeed, something like a periodic GitHub Action or something. I'm a bit worried that the problem matchers themselves won't change very often, whereas their location and the means to extract them from a possibly more complex json (like https://github.com/microsoft/vscode-cpptools/blob/a8285cbc0efb5b09c2d2229b0e0772dcb3b602df/Extension/package.json) will change more often, requiring more maintenance than it's worth. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants