fix: use typing.List to avoid list() method shadowing on Python 3.14#674
Open
cofin wants to merge 1 commit intolitestar-org:mainfrom
Open
fix: use typing.List to avoid list() method shadowing on Python 3.14#674cofin wants to merge 1 commit intolitestar-org:mainfrom
cofin wants to merge 1 commit intolitestar-org:mainfrom
Conversation
On Python 3.14 (PEP 649), lazy annotation evaluation resolves bare `list[...]` inside classes with a `list()` method to the method instead of the builtin type. Replace with `typing.List` in all affected class annotations. Closes litestar-org#659
cofin
force-pushed
the
fix/659-list-annotation
branch
from
ccefc3d to
aceaf54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list[...]withtyping.List[...]in all class annotations where the class defines alist()methodlistto the class method instead of the builtin typetyping.get_type_hints()Closes #659