Skip to content

Develop#14

Open
parkatoast wants to merge 3 commits intoljskatt:masterfrom
parkatoast:develop
Open

Develop#14
parkatoast wants to merge 3 commits intoljskatt:masterfrom
parkatoast:develop

Conversation

@parkatoast
Copy link
Contributor

Made a new branch, this is just an updated pull request of this with the latest commit added:
#13

Old commits:

  • Fix "Invoke-RestMethod:" error showing up when title is a program and not a series
    Updated Visual C++ 2010 link, as the old link led to a site that said "We're sorry, this download is no longer available." The new link leads to the newest version of Visual C++ 2010.
  • Updated program example, as the old one has been removed and the new example will seemingly stay on NRK TV forever, just like the other two examples.
  • Clarified FFmpeg's role within yt-dlp
  • Fixed some typos.

New commit:

  • Solves the issue of FFmpeg is in need of an update #12 which downloads a five year old version of FFmpeg. The new changes to the script makes it so that each time it's run without ffmpeg.exe in the same folder as the script, it downloads the newest FFmpeg version from gyan.dev and uses that.

- Updated Visual C++ 2010 link, as the old link led to a site that said "We're sorry, this download is no longer available." The new link leads to the newest version of Visual C++ 2010.
- Updated program example, as the old one has been removed and the new example will seemingly stay on NRK TV forever, just like the other two examples.
- Clarified FFmpeg's role within yt-dlp
- Fixed some typos.
The script first checks if what you have input is a series, and if it is, it proceeds without any complaints.

But if what you have input is a program, then you are met with something like this:

Invoke-RestMethod: C:\Users\Admin\Downloads\nrk-dl\nrk-dl.ps1:214
Line |
214 | … eries_req = Invoke-RestMethod -Uri "https://psapi.nrk.no/tv/catalog/s …
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| "AAAA00000000 is not an identifier for a series, but an identifier for a program."

It will still download, but seeing as this might be confusing to new users, I have added try-catch blocks to handle this silently.
The script will now always pull the newest FFmpeg build from gyan.dev, download and extract the .zip, pull the ffmpeg.bin from the extracted folder and delete the remnants, leaving only ffmpeg.exe.

It does not automatically check for new releases, so if you want the newest version from gyan.dev, then you must delete the ffmpeg.bin and run the script again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant