feat(finance): add Decimal support with precision control#1692
Open
rodrigobnogueira wants to merge 1 commit intolk-geimfari:masterfrom
Open
feat(finance): add Decimal support with precision control#1692rodrigobnogueira wants to merge 1 commit intolk-geimfari:masterfrom
rodrigobnogueira wants to merge 1 commit intolk-geimfari:masterfrom
Conversation
Add optional Decimal return type for price() and price_in_btc() methods to support high-precision financial calculations. Changes: - Add as_decimal parameter (default False) for backward compatibility - Add precision parameter to control decimal places - Use native Decimal generation (no intermediate float) - Add comprehensive tests for new functionality Closes lk-geimfari#1575
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
+ Coverage 98.90% 98.91% +0.01%
==========================================
Files 50 50
Lines 2098 2119 +21
==========================================
+ Hits 2075 2096 +21
Misses 23 23 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
Decimalreturn type forprice()andprice_in_btc()methods to support high-precision financial calculations.This implementation uses native Decimal generation via integer arithmetic — no intermediate float representation that could introduce precision errors.
Closes #1575
Changes
as_decimal: bool = Falseparameter for backward compatibilityprecision: intparameter to control decimal places (default 2 for price, 8 for BTC)Example Usage
Testing