Merged
Conversation
Before this patch, LNT had a rather complicated determination of where to store logs, especially given the fact that it is run under various layers (gunicorn, behind nginx, and docker). It would end up using a mixture of stderr logging and logging to lnt.log, which was rather confusing. This patch changes the webserver to always log only to stderr, which is a lot simpler and is the de-facto standard when running inside a Docker container. This makes it easier to retrieve logs by using the commands built into Docker, and it simplifies the code. When running outside of a Docker container, this is also a reasonable approach since we can redirect stderr as desired, for example using a utility like `rotatelogs`. Finally, this patch removes the `/log` API endpoint, which is arguably a hack and also a huge potential for leaking sensitive data. Fixes llvm#137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, LNT had a rather complicated determination of where to store logs, especially given the fact that it is run under various layers (gunicorn, behind nginx, and docker). It would end up using a mixture of stderr logging and logging to lnt.log, which was rather confusing.
This patch changes the webserver to always log only to stderr, which is a lot simpler and is the de-facto standard when running inside a Docker container. This makes it easier to retrieve logs by using the commands built into Docker, and it simplifies the code.
When running outside of a Docker container, this is also a reasonable approach since we can redirect stderr as desired, for example using a utility like
rotatelogs.Finally, this patch removes the
/logAPI endpoint, which is arguably a hack and also a huge potential for leaking sensitive data.Fixes #137