-
Notifications
You must be signed in to change notification settings - Fork 16k
[CodeGen] Simplify ExpandPostRA::LowerSubregToReg. NFC. #179634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SUBREG_TO_REG always has a non-zero subreg index so DstSubReg can never be the same as DstReg.
| MI->setDesc(TII->get(TargetOpcode::KILL)); | ||
| MI->removeOperand(3); // SubIdx | ||
| MI->removeOperand(1); // Imm | ||
| LLVM_DEBUG(dbgs() << "subreg: replaced by: " << *MI); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the tracing here for consistency ("replace" -> "replaced").
| return true; | ||
| } | ||
|
|
||
| LLVM_DEBUG(dbgs() << '\n'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this for consistency.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) lldb-apilldb-api.tools/lldb-dap/stopped-events/TestDAP_stopped_events.pyIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
SUBREG_TO_REG always has a non-zero subreg index so DstSubReg can never
be the same as DstReg.