Skip to content

Comments

Remove zero std dev tests#335

Merged
jagerber48 merged 19 commits intolmfit:mainfrom
jagerber48:no_zero_std_dev
Jul 14, 2025
Merged

Remove zero std dev tests#335
jagerber48 merged 19 commits intolmfit:mainfrom
jagerber48:no_zero_std_dev

Conversation

@jagerber48
Copy link
Contributor

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

Right now the tests raise many warnings about std_dev=0 not being supported. I am eliminating the tests that raise those warnings.

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.75%. Comparing base (53ac376) to head (45bce1b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_unumpy.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   86.79%   86.75%   -0.05%     
==========================================
  Files          18       18              
  Lines        1719     1706      -13     
==========================================
- Hits         1492     1480      -12     
+ Misses        227      226       -1     
Flag Coverage Δ
macos-latest-3.10 94.05% <ø> (ø)
macos-latest-3.11 94.05% <ø> (ø)
macos-latest-3.12 94.05% <ø> (ø)
macos-latest-3.8 94.05% <ø> (ø)
macos-latest-3.9 94.05% <ø> (ø)
no-numpy 82.64% <63.63%> (-0.08%) ⬇️
ubuntu-latest-3.10 94.05% <ø> (ø)
ubuntu-latest-3.11 94.05% <ø> (ø)
ubuntu-latest-3.12 94.05% <ø> (ø)
ubuntu-latest-3.8 94.05% <ø> (ø)
ubuntu-latest-3.9 94.05% <ø> (ø)
windows-latest-3.10 94.05% <ø> (ø)
windows-latest-3.11 94.05% <ø> (ø)
windows-latest-3.12 94.05% <ø> (ø)
windows-latest-3.8 94.05% <ø> (ø)
windows-latest-3.9 94.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 17, 2025

CodSpeed Performance Report

Merging #335 will not alter performance

Comparing jagerber48:no_zero_std_dev (45bce1b) with main (53ac376)

🎉 Hooray! pytest-codspeed just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 5 untouched benchmarks

@wshanks
Copy link
Contributor

wshanks commented Jun 18, 2025

Is this intended for master or main? It seems to have some changes in the docs unrelated to std dev tests.

@jagerber48 jagerber48 changed the base branch from master to main June 18, 2025 17:42
@jagerber48
Copy link
Contributor Author

jagerber48 commented Jun 18, 2025

Is this intended for master or main? It seems to have some changes in the docs unrelated to std dev tests.

Thanks, @wshanks it's meant for main. I switched it.

@jagerber48
Copy link
Contributor Author

This PR eliminated the warnings about std_dev==0. In some case this was removing tests, in some case it was changing tests. For tests involving formatting I chose to keep the tests and suppress the warnings rather than remove the tests.

I'm not ready to drop support/remove tests for formatting. involving std_dev==0. This is because, based on my experience with sciform, handling 0 std_dev edge cases is a major part of the complexity of formatting code. I don't think we should mess with this functionality until we have a solid plan for formatting next steps. Until then we should keep these tests in to keep track of the current behavior.

@jagerber48 jagerber48 merged commit 2c30134 into lmfit:main Jul 14, 2025
22 checks passed
@jagerber48 jagerber48 deleted the no_zero_std_dev branch July 14, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants