Rip out the downloadArchive job, and replace it with text instructions#360
Merged
Rip out the downloadArchive job, and replace it with text instructions#360
Conversation
SaptakS
reviewed
Jan 7, 2025
| </p> | ||
| <ul class="x-archive-steps"> | ||
| <li> | ||
| <strong>Visit <a href="#" @click="openURL('https://x.com/settings/download_your_data')"> |
Contributor
There was a problem hiding this comment.
Nitpick: Probably should be a <button> instead of a <a> since we are adding onclick function.
Member
Author
There was a problem hiding this comment.
I think I'm using <a> tags as buttons in various places, mostly so I could get the bootstrap link styles look right. Maybe we should go clean that up, but let's do it a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #359
Trying to download the archive within the webview is fine a lot of the time, but when it's not it can be very confusing. If it doesn't download for any reason (like an error message or redirection on X's side), the user interface still says "Downloading archive" in the status component (because that's the step it's on) and it's not clear what the user should be doing.
I recently helped a celebrity with 2M followers on X try to download his archive, and it just wouldn't work for him. During the step to prove your identity, it told him he had to contact X support, and there was a link that he couldn't click within Cyd because it was set to
target="_blank", which Cyd ignores.This PR bypasses all of these issues, and simplifies the app a little, by replacing the automatic stuff with some simple instructions: