Skip to content

document that the bearer token used for deletion is not a secret #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahflee merged 1 commit into from
Jan 23, 2025
Merged

document that the bearer token used for deletion is not a secret #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/renderer/src/view_models/AccountXViewModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export class AccountXViewModel extends BaseViewModel {
public currentJobIndex: number = 0;
public currentTweetItem: XTweetItem | null = null;

// This is used to track the user's progress through the wizard. If they want to review before
// This is used to track the user's progress through the wizard. If they want to review before
// they delete, this lets them go back and change settings without starting over
public isDeleteReviewActive: boolean = false;

Expand Down Expand Up @@ -218,6 +218,8 @@ export class AccountXViewModel extends BaseViewModel {
// Returns the API response's status code, or 0 on error
async graphqlDelete(ct0: string, url: string, referrer: string, body: string): Promise<number> {
this.log("graphqlDelete", [url, body]);
// Note: The Bearer token in the authorization header is X/Twitter's public web client bearer
// token used by x.com. It's publically visible in their web app and is not a secret.
return await this.getWebview()?.executeJavaScript(`
(async () => {
const transactionID = [...crypto.getRandomValues(new Uint8Array(95))].map((x, i) => (i = x / 255 * 61 | 0, String.fromCharCode(i + (i > 9 ? i > 35 ? 61 : 55 : 48)))).join('');
Expand Down Expand Up @@ -2672,7 +2674,7 @@ You can either import an X archive, or I can build it from scratch by scrolling
this.showBrowser = false;
await this.loadURL("about:blank");
this.instructions = `
I'll help you build a private local database of your X data to the \`Documents\` folder on your computer.
I'll help you build a private local database of your X data to the \`Documents\` folder on your computer.
You'll be able to access it even after you delete it from X.

**Which data do you want to save?**`;
Expand Down
Loading