-
Notifications
You must be signed in to change notification settings - Fork 8
feat(config, website): multi-seg, multi-ref searchUI mockup #5936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
anna-parker
wants to merge
32
commits into
add_count
Choose a base branch
from
search_ui_demo
base: add_count
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
078e54a
feat(config): add new metadataScope param
anna-parker 06ad216
wupps
anna-parker 8b8575d
wupps
anna-parker 40e9687
easy split
anna-parker 0bb292f
fix
anna-parker 501c4e9
more info for later
anna-parker f6b44d3
split by segment
anna-parker 66616fc
make reference selector per segment
anna-parker 6a4e401
partially fix mutation searches
anna-parker 3c3b88d
fixup
anna-parker 82839f1
add TODOs
anna-parker bfccba7
clean up some tests
anna-parker 1090510
fixup
anna-parker 3f5b1cd
fix final tests
anna-parker 34d4f3f
wupps
anna-parker 17b48cd
fix some displays
anna-parker 15652fc
fix name and order, make sections more prominent
anna-parker b7d39cc
fix reference selection
anna-parker b10f197
fix some tests
anna-parker 19039c5
fix download
anna-parker 5f8fead
format
anna-parker e03da4d
format
anna-parker f5f3dec
clean up code
anna-parker 7663524
clean up more
anna-parker 283a9d8
testing
anna-parker 10bf7fd
testing
anna-parker 12796e4
format
anna-parker 6ed3147
testing
anna-parker ffc57b4
try again
anna-parker de36c68
fix one test
anna-parker a8dbcae
fix one integration test
anna-parker cf49f1e
clean up tests a bit
anna-parker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should slim the config a bit:
When we have
preprocessing should get the arg
Additionally if we have
preprocessing should get the args
The prepro args are added by the template when
we should also add them automatically in the cases above to reduce to amount of boilerpoint config