Skip to content

chore(deployment,website,tests): remove dummy pipeline and organisms#5942

Draft
theosanderson wants to merge 8 commits intomainfrom
dummy2
Draft

chore(deployment,website,tests): remove dummy pipeline and organisms#5942
theosanderson wants to merge 8 commits intomainfrom
dummy2

Conversation

@theosanderson
Copy link
Member

@theosanderson theosanderson commented Feb 4, 2026

Remove Dummy Organisms and Dummy Preprocessing Pipeline

Summary

This PR removes the dummy-organism, dummy-organism-with-files, and the entire preprocessing/dummy directory while retaining all test coverage by migrating to use real organisms with nextclade preprocessing.

Changes

Kubernetes/Helm Configuration

  • Removed dummy-organism from values.yaml - tests now use ebola-sudan instead
  • Renamed dummy-organism-with-files to test-organism-files - this organism is used for file upload testing and now uses nextclade preprocessing instead of the dummy preprocessing pipeline
  • The test-organism-files organism:
    • Has consensusSequences: false (metadata-only, no sequences required)
    • Has file uploads enabled (raw_reads category)
    • Uses preprocessing-nextclade with no genes configured (for metadata-only processing)

Preprocessing Changes

Added file preservation to the nextclade preprocessing pipeline so that files attached to submissions are carried through to the processed output:

  • datatypes.py: Added files field to UnprocessedData class
  • backend.py: Extract files from backend JSON response when parsing unprocessed data
  • prepro.py: Pass files through to ProcessedData in the no-alignment code path

Integration Tests

Updated tests to use real organisms instead of dummy organisms:

  • file-sharing.spec.ts: Changed ORGANISM_URL_NAME from dummy-organism-with-files to test-organism-files
  • column-visibility.dependent.spec.ts: Changed from "Test Dummy Organism" to "Ebola Sudan"
  • landing-page.spec.ts: Changed featured organism to "Ebola Sudan"
  • navigation.spec.ts: Changed organism to "Ebola Sudan"
  • authentication.spec.ts: Changed URL from /dummy-organism/... to /ebola-sudan/...
  • submission.page.ts: Renamed fillSubmissionFormDummyOrganism to fillSubmissionFormFilesOrganism

Website

Updated the dev example data generator in SequenceEntryUploadComponent.tsx:

  • Now shows on ebola-sudan pages instead of dummy-organism pages
  • Generates ebola-sudan compatible metadata (submissionId, sampleCollectionDate, geoLocCountry, authorAffiliations)
  • Uses a valid ebola Sudan sequence for the sequence file

Deleted Files

  • preprocessing/dummy/ (entire directory including main.py, Dockerfile, mock-sequences.json, etc.)
  • .github/workflows/preprocessing-dummy-image.yml

CI/Workflow Updates

  • Removed trigger-dummy-preprocessing job from .github/workflows/build-arm-images.yaml

🚀 Preview: https://dummy2.loculus.org

theosanderson and others added 4 commits January 27, 2026 10:41
Added troubleshooting section for k3d setup and updated deployment instructions.
@claude claude bot added preprocessing Issues related to the preprocessing component deployment Code changes targetting the deployment infrastructure e2e E2E test related labels Feb 4, 2026
@theosanderson theosanderson added the preview Triggers a deployment to argocd label Feb 5, 2026
@theosanderson theosanderson changed the title Dummy2 chore(deployment,website,tests): remove dummy pipeline and organisms Feb 5, 2026
@theosanderson theosanderson marked this pull request as ready for review February 5, 2026 00:30
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks @theosanderson! Before reviewing the code in detail, I have a few general comments.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Will address these

Copy link
Member

@chaoran-chen chaoran-chen Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a short migration guide just as part of the PR description about how to migrate from the dummy pipeline to the Nextclade one. As the dummy pipeline was the only one that supported files, I've used it whenever showing someone how to set up an instance with files, so it would be good to have a link to send to people for migrating.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dummy pipeline is explicitly described as just for running tests and demonstrations, rather than for end-users, and I think that has been our consensus understanding of it as developers (hence tolerating various bugs), so I don't really consider this supported behaviour. At the time of implementation I did suggest implementing the functionality directly in the Nextclade pipeline. As below, I've no problem with us keeping the dummy pipeline around for weeks or a month, and of course I have no problem with anyone writing such a guide for when we remove it but atm I wouldn't personally plan to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the point above, as we've so far been using the dummy pipeline whenever we needed files, including in our live wastewater instance, it would be great if we can first test that the Nextclade pipeline is working well before the dummy pipeline gets dropped. Could we first merge the new Nextclade pipeline feature and changes to the Loculus previews but leave the old pipeline code and image for two more weeks after merging this PR before removing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there's no rush to remove the old version!

@anna-parker anna-parker self-requested a review February 5, 2026 07:00
dataIsLoaded={!!metadataFile && (!enableConsensusSequences || !!sequenceFile)}
/>
)}
{(organism.startsWith('not-aligned-organism') || organism === 'ebola-sudan') && action === 'submit' && (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hardcoded into Loculus so would appear on PPX for ebola sudan! Must fix :)

@theosanderson theosanderson marked this pull request as draft February 6, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Code changes targetting the deployment infrastructure e2e E2E test related preprocessing Issues related to the preprocessing component preview Triggers a deployment to argocd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants