[WIP ] rework configuration and documentation => better default#6
[WIP ] rework configuration and documentation => better default#6wiibaa wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
There was a problem hiding this comment.
I've been thinking about this, what if instead of having single/multiple setting with :mode, set instead a default for :clones ? For example:
config :clones, :validate => :array, :default => ["clone"]
this way the default behaviour of clone {} is the creation of 1 clone, and the clone will have type => clone
|
Any chance of merging this? I've just tried to use the clone filter with the current documentation and couldn't make it work. |
|
hi @anitakrueger, newer versions of the clone filter require |
|
@jsvd I saw this in the documentation, yes. Unfortunately there is no example present for the |
Reworked the plugin to achieve expected behaviour described in #1 => empty config create one clone.
But keep backward compatibility
Improved the documentation
@purbon or @jsvd I would need some guidance on correctly testing the yielded event in the spec if you extra time for review