feat: pin volume and workload pod to the original topology

[bachmanity1]

Which issue(s) this PR fixes:

Issue longhorn/longhorn#12517

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[bachmanity1]

I realized this can also be done using the Kubernetes VolumeZone scheduler plugin together with topology labels on the PV.

In this case, we would just need to add the zone label to the PV in the volume controller. Maybe we can add a new volume spec field to control this behavior. The labeling could be handled in ReconcilePersistentVolume function in the volume controller.

One advantage of this approach is that it works for both delayed and immediate binding modes. But even though the VolumeZone plugin is enabled by default, it’s a pretty old plugin and seems to be kept mostly for backward compatibility. From what I see, the recommended approach now is to use PV node affinity instead.

[bachmanity1]

I've updated the implementation based on my comment above. This feature now relies on the VolumeZone scheduler plugin. I think the current version is less complicated and more k8s-native. The previous version is here. If you prefer that one, please let me know.