chore: manually install VS build tools for Windows 2025 image#11188
Open
ksirvent wants to merge 3 commits intoloopbackio:masterfrom
Open
chore: manually install VS build tools for Windows 2025 image#11188ksirvent wants to merge 3 commits intoloopbackio:masterfrom
ksirvent wants to merge 3 commits intoloopbackio:masterfrom
Conversation
Signed-off-by: Kaila Sirvent <Kaila.Lopez-Sirvent@ibm.com>
Author
|
This PR is for testing purposes to see if Windows CI will pass. .husky changes will not be included in the final fix. Commented out temporarily as it was blocking me from committing the changes |
Member
|
@ksirvent, thanks for looking into this. Just a reminder that if you have multiple commits, all commits need to be signed. For the purpose of this PR, it would be better to have one commit. You can squash the commit when the PR is ready to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install VS build tools for Windows manually as Windows Server 2025 images do not include Visual Studio Build Tools by default
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈