feat(graphql): migrate to type-graphql 2.0.0-rc.2#11418
Open
lchudinov wants to merge 1 commit intoloopbackio:masterfrom
Open
feat(graphql): migrate to type-graphql 2.0.0-rc.2#11418lchudinov wants to merge 1 commit intoloopbackio:masterfrom
lchudinov wants to merge 1 commit intoloopbackio:masterfrom
Conversation
lchudinov
changed the title
lchudinov
force-pushed
the
feature/migrate-graphql-extension-to-type-graphql-2-0-0-rc-2
branch
4 times, most recently
from
2ee0850 to
0a104fb
Compare
Pull Request Test Coverage Report for Build 21538622890Details
💛 - Coveralls |
lchudinov
changed the title
lchudinov
force-pushed
the
feature/migrate-graphql-extension-to-type-graphql-2-0-0-rc-2
branch
2 times, most recently
from
4f9291c to
0885dfe
Compare
Contributor
Author
|
Hi @dhmlau, Could you please review this PR? |
dhmlau
approved these changes
Jan 30, 2026
Member
dhmlau
left a comment
dhmlau
left a comment
There was a problem hiding this comment.
@lchudinov, thanks for the PR. The changes look reasonable to me. I'm not familiar with this extension, so it would be ideal to have at least one more review before we land this PR.
Also, I have a question about one file. Thanks.
packages/cli/test/fixtures/copyright/single-package/src/application.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Leonty Chudinov <leonty.chudinov@gmail.com>
lchudinov
force-pushed
the
feature/migrate-graphql-extension-to-type-graphql-2-0-0-rc-2
branch
from
0885dfe to
226823c
Compare
Contributor
Author
|
@dhmlau, Thanks for your approval. Could you please add a reviewer who is familiar with the extension? |
Member
|
@lchudinov , @raymondfeng is listed as codeowner for this extension. |
Contributor
Author
|
@dhmlau Sure, I agree. Waiting until next week sounds good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[graphql] Migrate GraphQL Extension to type-graphql v2.0.0-rc.2
The GraphQL extension currently uses
type-graphqlversion2.0.0-beta.2.This PR migrates the extension to the latest release candidate,
2.0.0-rc.2.Checklist
npm testpasses on your machineexamples/*were updated