Restore Pos conversion to mcDEFAULT homing mode#5
Open
AndrewMusser wants to merge 2 commits intomainfrom
Open
Conversation
Member
|
@AndrewMusser Do you remember anything about this? |
Contributor
Author
@Joshpolansky Yes, vaguely. I think we did this because Mapp Motion handles the restore pos in an automated way for you when you map a PV in the drive's configuration? |
Member
Was there a reason we didn't use it? |
Member
|
Based on testing with MpRobotFlex I'm not sure the drive automatically handles the homing if data is valid. Is that your understanding? I was wondering if it's MpAxisBasic that does the restore pos? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies AxisLib's reference FUB to handle restore pos homing modes differently. The general idea is to leverage more of Mapp Motion's 'out-of-the-box' capabilities with Restore Pos homing: