Making callback in Handler escaping to allow async usage#3
Open
lowip wants to merge 1 commit intolovesunstar:masterfrom
Open
Making callback in Handler escaping to allow async usage#3lowip wants to merge 1 commit intolovesunstar:masterfrom
lowip wants to merge 1 commit intolovesunstar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made to the project are in WKBridge/Classes/Bridge.swift, others changes are the result of using the latest version of the WKBridge pod (executing
pod install) in the example project.I made the
callbackin theHandlertypealias@escapingto allow asynchronous usage.My use case for this change is to perform network operations in the native layer (using
Foundation) to avoid CORS issues.