Skip to content

Remove the filter excluding quality.cpp from the tests#674

Merged
costamag merged 1 commit intolsils:masterfrom
costamag:complete-workflow
May 5, 2025
Merged

Remove the filter excluding quality.cpp from the tests#674
costamag merged 1 commit intolsils:masterfrom
costamag:complete-workflow

Conversation

@costamag
Copy link
Contributor

@costamag costamag commented May 1, 2025

The quality.cpp file was previously excluded from the test workflow, which prevented the CI from detecting issues introduced in earlier PRs ( #668 ). This PR ensures that quality.cpp is properly included, allowing the workflow to catch potential errors that would otherwise only be noticed during local compilation.

It would be good to hear from previous contributors if there is a good reason why quality.cpp should be excluded from the workflow run ( @lee30sonia, @aletempiac )

@costamag costamag changed the title ci: remove the filter excluding quality.cpp from the tests Remove the filter excluding quality.cpp from the tests May 2, 2025
@costamag
Copy link
Contributor Author

costamag commented May 5, 2025

Hi @changmg,
@lee30sonia mentioned offline that the filter was introduced to speed up the test run. If we decide to restore the filter, I'm happy to work on increasing the test coverage so that it still catches the issue of the PR #668.

@aletempiac
Copy link
Member

Hi @costamag,
We can try restoring it again and check the runtime increase in running the tests. It should be affordable. It is definitely a good idea to have quality checks on commits, especially when getting PRs from outside the lsils group.

@costamag
Copy link
Contributor Author

costamag commented May 5, 2025

Hi @aletempiac,
Thank you for your feedback! Sounds good. Let’s go ahead and restore them for now.

@costamag costamag merged commit 44ebcb3 into lsils:master May 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants