(hiera/common.yaml) add rsyslog logrotate#1213
Open
cbarria wants to merge 1 commit intoproductionfrom
Open
Conversation
cbarria
changed the title
cbarria
changed the title
cbarria
force-pushed
the
IT-5347_rsyslog_rotate
branch
from
6b3ecdc to
150b34c
Compare
cbarria
force-pushed
the
IT-5347_rsyslog_rotate
branch
from
150b34c to
ee6e969
Compare
cbarria
requested review from
badenerb,
csilva-cl,
dtapiacl,
igonzalezcl and
jhoblitt
cbarria
changed the title
jhoblitt
reviewed
Jun 11, 2024
Member
jhoblitt
left a comment
jhoblitt
left a comment
There was a problem hiding this comment.
Was this tested on EL7 and EL8? It will probably work but I don't know how the existing /etc/logrotate.d.rsyslog are different.
cbarria
force-pushed
the
IT-5347_rsyslog_rotate
branch
from
ee6e969 to
8ba8be0
Compare
Contributor
Author
this was tested on the foreman dev host with EL7 and some other EL8 cant recall the host 👍🏻 |
cbarria
force-pushed
the
IT-5347_rsyslog_rotate
branch
from
8ba8be0 to
fd4ea3f
Compare
jhoblitt
reviewed
Aug 12, 2024
Member
jhoblitt
left a comment
jhoblitt
left a comment
There was a problem hiding this comment.
This is going to apply to EL7, EL8, EL9, and the couple of Ubuntu nodes. Has this file been inspected on all of the platforms?
dtapiacl
force-pushed
the
IT-5347_rsyslog_rotate
branch
from
fd4ea3f to
7639964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
are you constantly out of space on your disks? is your node always tainted with disk pressure? is your CNI complaining and your canal pods are unable to start? Well... logs are no longer going to be THAT problem, only if you click Approve 👌🏻